Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

[Nicolás Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121283/#review72347
-----------------------------------------------------------


MSVC2012 doesn't support default template parameters on function templates. You'll have to pick a different way of using enable_if, such as wrapping the return type or adding a default non-template parameter.

There is a nice list on the Remarks section of http://msdn.microsoft.com/en-us/library/ee361639.aspx (scenario 3 is the one that doesn't work).

- Nicolás Alvarez


On Nov. 30, 2014, 11:11 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121283/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 11:11 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Allow using new style connect in KActionCollection::add[Action]()
> 
> 
> Diffs
> -----
> 
>   src/kactioncollection.h 879f59201111bddc04c9ff48d137ae386a860382 
> 
> Diff: https://git.reviewboard.kde.org/r/121283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141220/7c3d560c/attachment.html>