Review Request 121079: Fix building dolphin tests on MSVC
David Faure
faure at kde.org
Sat Dec 20 15:06:22 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/#review72341
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121079/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 10:26 p.m.)
>
>
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> MSVC complains about missing symbols from their respective moc files on linking step.
>
>
> Diffs
> -----
>
> dolphin/src/tests/CMakeLists.txt 60f6517
>
> Diff: https://git.reviewboard.kde.org/r/121079/diff/
>
>
> Testing
> -------
>
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141220/13dd44f5/attachment.html>
More information about the Kde-frameworks-devel
mailing list