Review Request 121315: Allow using kded modules with JSON metadata

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121315/#review72335
-----------------------------------------------------------

Ship it!


Looks good to me overall (for the details, you're the expert ;)

Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is that documented somewhere else BTW?

(Right now I would even need a solution for KMimeTypeTrader -> KPluginMetaData, but filtering by mimetype doesn't seem to be available?)


src/kded.cpp
<https://git.reviewboard.kde.org/r/121315/#comment50434>

    strange empty line here


- David Faure


On Dec. 1, 2014, 4:29 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121315/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 4:29 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> The old .desktop based ones will still be loaded (with a debug message).
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp 40e549f6443d5cd2b26c5f9bad9695462a3467aa 
>   src/kded.h a91a94ce1e68032156eb070bdb1e722410d44b64 
> 
> Diff: https://git.reviewboard.kde.org/r/121315/diff/
> 
> 
> Testing
> -------
> 
> everything seems to work correctly.
> 
> No plugins are converted yet so they are all still loaded from .desktop files
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141220/c03047ad/attachment.html>