Review Request 121595: Always return absolute paths in Kdelibs4Migration

Marco Martin notmart at gmail.com
Fri Dec 19 11:56:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121595/#review72297
-----------------------------------------------------------

Ship it!


tested it on a clean system, seems to solve the issue

- Marco Martin


On Dec. 19, 2014, 11:55 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121595/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 11:55 a.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> KDELibs4Migration returns an absolute path in the case that .kde or
> .kde4 exist.
> 
> If that folder does not exist and we fall back to KDE4_DEFAULT_HOME we
> also want an absolute path, which currently is not happening.
> 
> This fixes the kde4breeze script which is launched from kconf_update
> writing a kdeglobals file in the wrong directory.
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kdelibs4migration.cpp 4a6ba0d 
> 
> Diff: https://git.reviewboard.kde.org/r/121595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141219/704feabb/attachment.html>


More information about the Kde-frameworks-devel mailing list