Review Request 121575: FindEpoxy.cmake

[Jan Kundrát]

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote:
> > find-modules/Findepoxy.cmake, line 14
> > <https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14>
> >
> >     I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like now proposed in kdeclarative) if it has a huge if not win32 block.
> 
> Marco Martin wrote:
>     ah, doesn't support windows at all? even for libplasma isn't that good then.
>     how much boilerplate would be needed to not use it for the graph thing?

There are some remarks about win32 at https://github.com/anholt/libepoxy and their release page contains a "win32 version", so I think there's at least some upstream support. The "if not block" Martin mentioned exists in the CMakeLists.txt.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121575/#review72229
-----------------------------------------------------------


On Dec. 17, 2014, 10:35 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121575/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 10:35 a.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Both Plasma and KWin now depend from the epoxy opengl library.
> So would be better to have the necessary cmake stuff in ecm instead of having it copied in the two repos.
> This is the file coming from KWin
> 
> 
> Diffs
> -----
> 
>   find-modules/Findepoxy.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141218/91172d5c/attachment.html>