Review Request 121575: FindEpoxy.cmake

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121575/#review72229
-----------------------------------------------------------



find-modules/Findepoxy.cmake
<https://git.reviewboard.kde.org/r/121575/#comment50388>

    I just need to point out that I consider epoxy as a bad dependency for usage in a cross platform library (like now proposed in kdeclarative) if it has a huge if not win32 block.


- Martin Gräßlin


On Dec. 17, 2014, 11:35 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121575/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 11:35 a.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Both Plasma and KWin now depend from the epoxy opengl library.
> So would be better to have the necessary cmake stuff in ecm instead of having it copied in the two repos.
> This is the file coming from KWin
> 
> 
> Diffs
> -----
> 
>   find-modules/Findepoxy.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141218/b0fc1a4f/attachment.html>