Review Request 121562: Fix build with Qt 5.5/dev branch in release mode

David Edmundson david at davidedmundson.co.uk
Tue Dec 16 18:01:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121562/#review72131
-----------------------------------------------------------


+1

- David Edmundson


On Dec. 16, 2014, 5:42 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121562/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 5:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its argument for validity" the build shall fail.
> alternative is to guard the Q_ASSERT with QT_NO_DEBUG
> 
> 
> Diffs
> -----
> 
>   src/kselectionproxymodel.cpp 6774b75 
> 
> Diff: https://git.reviewboard.kde.org/r/121562/diff/
> 
> 
> Testing
> -------
> 
> does what it advertises
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141216/d5a731b2/attachment.html>


More information about the Kde-frameworks-devel mailing list