Review Request 121536: Actually set the palette when it changes

[Martin Gräßlin]

> On Dec. 15, 2014, 5:58 p.m., Martin Gräßlin wrote:
> > src/platformtheme/khintssettings.cpp, lines 209-211
> > <https://git.reviewboard.kde.org/r/121536/diff/1/?file=333385#file333385line209>
> >
> >     shouldn't that be QGuiApplication?
> 
> David Edmundson wrote:
>     You would have thought so, but it doesn't work.
>     
>     I could do an else if (QGuiApplication) {QGuiApplication::setPalette}

wow that's quite a wtf!There is both QGuiApplication::setPalette and QApplication::setPalette. So yes, I thing we need an else if block.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121536/#review72074
-----------------------------------------------------------


On Dec. 15, 2014, 5:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121536/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Actually set the palette when it changes
> 
> Simply emitting an event that the palette has changed has absolutely no effect
> as QApplication keeps a cache of the palette, we need to update that appropriately
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.cpp 8799216 
> 
> Diff: https://git.reviewboard.kde.org/r/121536/diff/
> 
> 
> Testing
> -------
> 
> Opened systemsettings5 changed my colour scheme and had it work immediately.
> 
> Breeze seems to have an issue updating tabview widgets on the fly but that's a separate issue.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141215/fa5cdd8c/attachment.html>