Review Request 121536: Actually set the palette when it changes

Martin Gräßlin mgraesslin at kde.org
Mon Dec 15 16:58:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121536/#review72074
-----------------------------------------------------------



src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/121536/#comment50266>

    shouldn't that be QGuiApplication?


- Martin Gräßlin


On Dec. 15, 2014, 5:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121536/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Actually set the palette when it changes
> 
> Simply emitting an event that the palette has changed has absolutely no effect
> as QApplication keeps a cache of the palette, we need to update that appropriately
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.cpp 8799216 
> 
> Diff: https://git.reviewboard.kde.org/r/121536/diff/
> 
> 
> Testing
> -------
> 
> Opened systemsettings5 changed my colour scheme and had it work immediately.
> 
> Breeze seems to have an issue updating tabview widgets on the fly but that's a separate issue.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141215/9ba01d93/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list