Review Request 121461: Fix for bug 341773 and minor changes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review71892
-----------------------------------------------------------


A unittest for ".foo" is missing, now that you're special-casing known extensions such as ".txt".
(e.g. the ".kde" directory)


src/core/global.cpp
<https://git.reviewboard.kde.org/r/121461/#comment50118>

    toLocalFile() returns empty for remote URLs. A full path isn't needed though. Just call suffixForFileName(oldName).


- David Faure


On Dec. 12, 2014, 3:30 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121461/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2014, 3:30 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 341773
>     https://bugs.kde.org/show_bug.cgi?id=341773
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the extension.
> 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't be changing that.
> 
> 
> Diffs
> -----
> 
>   autotests/globaltest.cpp 06cb500 
>   src/core/global.cpp f18ac10 
> 
> Diff: https://git.reviewboard.kde.org/r/121461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141212/920c2ba4/attachment.html>