Review Request 121448: Introduce ECMAddAppIcon.

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/#review71859
-----------------------------------------------------------



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/121448/#comment50079>

    Just recgonized that using list() do not propagate the added file to the parent scope. I had to change this line to 
    
    set(${appsources} "${${appsources}};${_outfilename}.rc" PARENT_SCOPE)



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/121448/#comment50080>

    dito
    
    set(${appsources} "${${appsources}};${_outfilename}.icns" PARENT_SCOPE)


- Ralf Habacker


On Dez. 11, 2014, 4:40 nachm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121448/
> -----------------------------------------------------------
> 
> (Updated Dez. 11, 2014, 4:40 nachm.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
> supports platform specific application icon for Windows and Mac OSX.
> 
> On Windows this function depends on the external tool png2ico, which is
> provided by the kdewin-tools binary package. Sources are available at
> https://projects.kde.org/projects/kdesupport/kdewin.
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141212/e5909cb9/attachment-0001.html>