Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

Gregor Mi codestruct at posteo.org
Fri Dec 12 11:04:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121379/
-----------------------------------------------------------

(Updated Dec. 12, 2014, 11:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Feck and Dominik Haumann.


Repository: kwidgetsaddons


Description
-------

As mentioned in [KPageView/KTitleWidget: Remove top right icon](https://forum.kde.org/viewtopic.php?f=285&t=123837) the top-right icon serves no visible purpose and can even be a distraction. This patch removes the code that adds the icon.


Diffs
-----

  src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1 

Diff: https://git.reviewboard.kde.org/r/121379/diff/


Testing
-------

Screenshots:
http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch)
http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after)


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141212/1f7db438/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list