Review Request 121461: Fix for bug 341773 and minor changes

Arjun AK arjunak234 at gmail.com
Fri Dec 12 10:56:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Bugs: 341773
    https://bugs.kde.org/show_bug.cgi?id=341773


Repository: kio


Description
-------

1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the extension.
2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't be changing that.


Diffs
-----

  autotests/globaltest.cpp 06cb500 
  src/core/global.cpp f18ac10 

Diff: https://git.reviewboard.kde.org/r/121461/diff/


Testing
-------


Thanks,

Arjun AK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141212/a16010a7/attachment.html>


More information about the Kde-frameworks-devel mailing list