Review Request 119607: Support for ".hidden" files

[Bruno Nova]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
-----------------------------------------------------------

(Updated Dez. 11, 2014, 3:23 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

The patch was not working everywhere. Using `QFileInfo::canonicalPath()` to determine the parent directory was not a very bright idea (it didn't work when the first file was a symlink, obviously). I replaced it by `QFileInfo::absolutePath()`, which seems to work correctly.
I also rebased the patch on the latest version from *git master*, and am now using KubuntuCI to test it.
I'll now try to see if I can get the unit tests done.


Bugs: 64740 and 246260
    https://bugs.kde.org/show_bug.cgi?id=64740
    https://bugs.kde.org/show_bug.cgi?id=246260


Repository: kio


Description
-------

This adds support for *.hidden* files to KDE.

When listing a directory, the files/folders listed in the *.hidden* file will be hidden, unless the user has chosen to show hidden files.

This patch was initially based on the patch provided by Mark in Bug #246260.


Diffs (updated)
-----

  src/core/kcoredirlister.cpp f5c5627 
  src/core/kcoredirlister_p.h db096c5 
  src/core/kfileitem.h a815aee 
  src/core/kfileitem.cpp 6a2cfa5 

Diff: https://git.reviewboard.kde.org/r/119607/diff/


Testing
-------

Built and tested the patch in Project Neon.
Dolphin was still using KDE4/Qt4 version of the library, so I only tested using the desktop folder widget, and "folder desktop".
It worked correctly when I pointed it to "~" and "~/Desktop" (I added ".hidden" there).
However, it didn't work when I pointed it to the "Desktop folder" (the default option, not the custom location "~/Desktop").
More testing is required.

The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget and detailed/tree view in Dolphin).
It wasn't an intensive test, though.


Thanks,

Bruno Nova

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141211/448efd9b/attachment.html>