Review Request 121411: Don't trigger animation if size changed.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121411/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 3:55 a.m.)


Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe Broulik.


Changes
-------

Let's just make this simpler first. Stop animation if the pixmap change is caused by the geometry change.


Repository: plasma-framework


Description
-------

Making transition between two different size doesn't make much sense, since repainting is usually happens at that time and it could take some time to finish. And animation need to be stopped if m_animValue is set manually.


Diffs (updated)
-----

  src/declarativeimports/core/iconitem.cpp 145a7cd 

Diff: https://git.reviewboard.kde.org/r/121411/diff/


Testing (updated)
-------

Looks fine on tray icon and lock screen, less blurry transition.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141211/b743d7e7/attachment.html>