New framework to review: KPackage

Marco Martin notmart at gmail.com
Wed Dec 10 09:56:41 UTC 2014


On Wednesday 10 December 2014, Albert Astals Cid wrote:
> > I would like to submit it (kpackage repo) for the usual 2 weeks period of
> > review.
> 
> Add const &
>     void setDefaultMimeTypes(QStringList mimeTypes);
>     void setMimeTypes(const char *key, QStringList mimeTypes);
> 
> You probably want a Q_DISABLE_COPY or similar in PackageLoader

done

> Add const &
>     foreach (QString prefix, d->contentsPrefixPaths) {

done

> 
> All those "char *" params make me a bit unhappy, any reason those are not
> QString or QByteArray?

made them QByteArrays


-- 
Marco Martin


More information about the Kde-frameworks-devel mailing list