Review Request 121411: Don't trigger animation if size changed.

Xuetian Weng wengxt at gmail.com
Tue Dec 9 16:43:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121411/
-----------------------------------------------------------

Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe Broulik.


Repository: plasma-framework


Description
-------

Making transition between two different size doesn't make much sense, since repainting is usually happens at that time and it could take some time to finish. And animation need to be stopped if m_animValue is set manually.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp ed3bb978f01cca98315fd425778139e4b9eeb64f 

Diff: https://git.reviewboard.kde.org/r/121411/diff/


Testing
-------

Looks fine on tray icon and lock screen, no blurry transition anymore.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141209/aba123fb/attachment.html>


More information about the Kde-frameworks-devel mailing list