Review Request 121372: Differeniate between bookmarks for documents and the web

[Gun Chleoc]

> On Dec. 8, 2014, 8:40 p.m., Albert Astals Cid wrote:
> > I don't think this makes sense at a framework level. If some application is so special that really needs a special case, they can call setText over the kaction themselves, otherwise we're going to end up havin 20 different "Add Bookmark" for all the minor technicalities of over what it is applied.
> 
> Gun Chleoc wrote:
>     I'm the person who originally filed the bug. Since I'm just translating and new to KDE, can you give me a recommendation if I should translate this as "bookmarks" or "webmarks" then? I don't know if web or document applications are more frequent in KDE, and we should minimize the number of applications that I will have to file bugs with. This is a linguistic issue rather than an application being "special" - English is just more ambiguous than my language in this case.
> 
> Albert Astals Cid wrote:
>     You should translate bookmark. If you need bookmark in a web application to be translatable different than bookmark, then file a bug agains that application and ask them to. I am unconvinced a framework has to support all the combinatorials of application use of bookmark multiplied by the various languages that can have different translations for the various uses of bookrmak in various cases.
> 
> Matthew Dawson wrote:
>     Based on these comments then, I'm going to discard this RR and close the bug as WONTFIX with a pointer back to here.  Thanks for the help!

Thank you for your help and sorry for the extra coding work that won't be used now.


- Gun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121372/#review71585
-----------------------------------------------------------


On Dec. 9, 2014, 4:41 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121372/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 4:41 a.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and Matthew Dawson.
> 
> 
> Bugs: 341279
>     https://bugs.kde.org/show_bug.cgi?id=341279
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> As requested in bug #1164383, this adds a new standard shortcut
> for adding bookmarks for web pages.
> 
> BUG: 1164383
> 
> I'm not sure if this is the best approach.  If this is accpted, I'll commit a similar change into KConfigWidgets.
> 
> 
> Diffs
> -----
> 
>   src/gui/kstandardshortcut.h 5bb07fb9f060b0d5950aed251da985ce3aa46661 
>   src/gui/kstandardshortcut.cpp 84007374c2836c1d61cb9b9361bd4217aa4ddc32 
> 
> Diff: https://git.reviewboard.kde.org/r/121372/diff/
> 
> 
> Testing
> -------
> 
> Compiles, verified context extracted properly into pot file.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141209/00908a31/attachment.html>