Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

Nicolás Alvarez nicolas.alvarez at gmail.com
Tue Dec 9 03:24:42 UTC 2014


2014-12-08 23:37 GMT-03:00 Nicolás Alvarez <nicolas.alvarez at gmail.com>:
>> https://git.reviewboard.kde.org/r/121094/
>
> This change fails to compile on Windows, because the unit test has
> ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons
> library which obviously defines the same function. In addition,
> ktexttohtml.h in this context is declaring the function as
> __declspec(dllimport), so it expects them to find the function in a linked
> library. All this causes a multiple definition error when linking the unit
> test.
>
> I see it's being done this way in order to test the private API, but I'm not
> sure how to fix it.
>
> Is anyone else testing non-exported API in KF5?

I have fixed this build error (d5aa34a3), based on how knewstuff does it :)

-- 
Nicolás


More information about the Kde-frameworks-devel mailing list