Review Request 121397: Remove NotifyBySound

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121397/#review71596
-----------------------------------------------------------

Ship it!



src/knotificationmanager.cpp
<https://git.reviewboard.kde.org/r/121397/#comment49924>

    Can you also remove this line please, makes no sense now


- Martin Klapetek


On Dec. 8, 2014, 11:42 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121397/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 11:42 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> NotifyByAudio implements the "Sound" notification already
> 
> Based on comments from https://git.reviewboard.kde.org/r/121356/
> 
> 
> Diffs
> -----
> 
>   src/knotificationmanager.cpp 9f180b4 
>   src/notifybysound.h 1efa620 
>   src/notifybysound.cpp 09a80dd 
> 
> Diff: https://git.reviewboard.kde.org/r/121397/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141208/d7c4c156/attachment-0001.html>