Review Request 121372: Differeniate between bookmarks for documents and the web

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121372/#review71585
-----------------------------------------------------------


I don't think this makes sense at a framework level. If some application is so special that really needs a special case, they can call setText over the kaction themselves, otherwise we're going to end up havin 20 different "Add Bookmark" for all the minor technicalities of over what it is applied.

- Albert Astals Cid


On des. 6, 2014, 8:49 p.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121372/
> -----------------------------------------------------------
> 
> (Updated des. 6, 2014, 8:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and Matthew Dawson.
> 
> 
> Bugs: 341279
>     https://bugs.kde.org/show_bug.cgi?id=341279
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> As requested in bug #1164383, this adds a new standard shortcut
> for adding bookmarks for web pages.
> 
> BUG: 1164383
> 
> I'm not sure if this is the best approach.  If this is accpted, I'll commit a similar change into KConfigWidgets.
> 
> 
> Diffs
> -----
> 
>   src/gui/kstandardshortcut.h 5bb07fb9f060b0d5950aed251da985ce3aa46661 
>   src/gui/kstandardshortcut.cpp 84007374c2836c1d61cb9b9361bd4217aa4ddc32 
> 
> Diff: https://git.reviewboard.kde.org/r/121372/diff/
> 
> 
> Testing
> -------
> 
> Compiles, verified context extracted properly into pot file.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141208/c3a1cb67/attachment.html>