Review Request 121299: Add NET::OSD window type
Kai Uwe Broulik
kde at privat.broulik.de
Mon Dec 8 14:48:24 UTC 2014
On Dez. 8, 2014, 9:34 vorm., Kai Uwe Broulik wrote:
> > the autotest for NET::Supported is not extended for the new supported type
>
> Martin Gräßlin wrote:
> I'm still missing the extension of the autotest. In fact I'd expect that at least one autotest is currently failing.
Could you be more specific about which test you are referring to? I added OSD testdata whereever I found a reference to the Notification type.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299/#review71540
-----------------------------------------------------------
On Dez. 8, 2014, 1:40 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121299/
> -----------------------------------------------------------
>
> (Updated Dez. 8, 2014, 1:40 nachm.)
>
>
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> This adds a NET::OSD window type for the OSD (eg. volume feedback) so it can be placed even ontop of active fullscreen windows in contrast to the Notifications.
>
> Not sure whether a kde netwm thing is required or we could just use some other method in KWin to decide placement.
>
> Also dunno what impact on ABI this has, I tried to only add enum values at the end.
>
>
> Diffs
> -----
>
> autotests/kwindowinfox11test.cpp 5c8ee8a
> autotests/netwininfotestclient.cpp 16ba4b3
> src/netwm.cpp 1ccba32
> src/netwm_def.h 0352f33
>
> Diff: https://git.reviewboard.kde.org/r/121299/diff/
>
>
> Testing
> -------
>
> In conjunction with Review 121300 these are now ontop of fullscreen windows.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141208/e1b63acf/attachment.html>
More information about the Kde-frameworks-devel
mailing list