Review Request 121090: Move kio-mtp to kio-extras

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review71545
-----------------------------------------------------------


Looks good. It's too much code for me to review properly; but as it's basically the same as the KDE4 version. +1.


mtp/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121090/#comment49902>

    You're using i18n, but I don't see you set a translation domain anywhere.



mtp/README
<https://git.reviewboard.kde.org/r/121090/#comment49900>

    This is all lies.



mtp/kio_mtp.cpp
<https://git.reviewboard.kde.org/r/121090/#comment49903>

    who deletes this?



mtp/kio_mtp.cpp
<https://git.reviewboard.kde.org/r/121090/#comment49901>

    this has _new_ in the functtion name, so I assume it allocates memory, if so who deletes it? It's not being done in this scope.


- David Edmundson


On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121090/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 9:30 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style.
> 
> Discussion about this move can be found here http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2
> 
> 
> Diffs
> -----
> 
>   mtp/kio_mtp_helpers.h PRE-CREATION 
>   mtp/kio_mtp_helpers.cpp PRE-CREATION 
>   mtp/mtp-network.desktop PRE-CREATION 
>   mtp/mtp.protocol PRE-CREATION 
>   mtp/solid_mtp.desktop PRE-CREATION 
>   mtp/filecache.cpp PRE-CREATION 
>   mtp/kio-mtp.kdev4 PRE-CREATION 
>   mtp/kio_mtp.h PRE-CREATION 
>   mtp/kio_mtp.cpp PRE-CREATION 
>   CMakeLists.txt 8f82688 
>   mtp/CMakeLists.txt PRE-CREATION 
>   mtp/COPYING PRE-CREATION 
>   mtp/LICENCE PRE-CREATION 
>   mtp/Messages.sh PRE-CREATION 
>   mtp/README PRE-CREATION 
>   mtp/devicecache.h PRE-CREATION 
>   mtp/devicecache.cpp PRE-CREATION 
>   mtp/filecache.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121090/diff/
> 
> 
> Testing
> -------
> 
> I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141208/f5a4b4ed/attachment.html>