Change in kio[master]: Fix test invocation when there's no /usr/bin/gs

[Jan Kundrát (Code Review)]

Jan Kundrát has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/204

Change subject: Fix test invocation when there's no /usr/bin/gs
......................................................................

Fix test invocation when there's no /usr/bin/gs

The test assumed that an executable called /usr/bin/gs is present on the
system which is running the test. That's a can of worms, IMHO, as that
dependency is not specified anywhere, and users are in general free to
massage their $PATH and what not. There's certainly no /usr/bin/gs on a
CI system I'm playing with right now.

At the same time, the test appears to require at least one well-known
executable name using full path. Let's stick with /bin/bash, that has
quite high chance of being around on any given system.

Change-Id: I50ade4f5bde3193f0607d9b3c74592117d810192
---
M autotests/kurifiltertest.cpp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/kio refs/changes/04/204/1

diff --git a/autotests/kurifiltertest.cpp b/autotests/kurifiltertest.cpp
index 6b954ab..6d26472 100644
--- a/autotests/kurifiltertest.cpp
+++ b/autotests/kurifiltertest.cpp
@@ -365,8 +365,8 @@
     addRow( "/I/dont/exist", 0, KUriFilterData::Error, minicliFilters );         //krazy:exclude=spelling
     addRow( "/I/dont/exist#a", 0, KUriFilterData::Error, minicliFilters );       //krazy:exclude=spelling
     addRow( "kbuildsycoca5 --help", "kbuildsycoca5 --help", KUriFilterData::Executable, minicliFilters ); // the args are in argsAndOptions()
-    addRow( "/usr/bin/gs", "/usr/bin/gs", KUriFilterData::Executable, minicliFilters );
-    addRow( "/usr/bin/gs -q -option arg1", "/usr/bin/gs -q -option arg1", KUriFilterData::Executable, minicliFilters ); // the args are in argsAndOptions()
+    addRow( "/bin/bash", "/bin/bash", KUriFilterData::Executable, minicliFilters );
+    addRow( "/bin/bash -q -option arg1", "/bin/bash -q -option arg1", KUriFilterData::Executable, minicliFilters ); // the args are in argsAndOptions()
 
     // Typing 'cp' or any other valid unix command in konq's location bar should result in
     // a search using the default search engine

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/204
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50ade4f5bde3193f0607d9b3c74592117d810192
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Jan Kundrát <jkt at kde.org>
Gerrit-Reviewer: Alex Merry <alex.merry at kde.org>