Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120904/#review71459
-----------------------------------------------------------


Indeed given the QChar API I don't see a better way.


src/kcharselect.h
<https://git.reviewboard.kde.org/r/120904/#comment49857>

    in other methods you say P==Plane, here you say P==Page, looks like a typo?



src/kcharselect.h
<https://git.reviewboard.kde.org/r/120904/#comment49858>

    same


- David Faure


On Oct. 30, 2014, 2:02 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120904/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Daniel Laidig.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> To be able to fix bug 142625 we need new API in KCharSelect.
> 
> I am not completely sure if we should do it in KWidgetsAddons at all, because the required data updates might unreasonable blow up the size of the repository, but I just came up with this proposal for the API. Note that only the header diff is shown for the API review, the .cpp changes can be done after we settle for something.
> 
> Some things to discuss:
> * uint is used by static QChar functions as the datatype, I adopted it
> * it might make sense to have a function that returns the currently selected character(s) as a simple QString, with all UTF-16 handling already done. Naming suggestions?
> 
> 
> Diffs
> -----
> 
>   src/kcharselect.h ec93d21 
> 
> Diff: https://git.reviewboard.kde.org/r/120904/diff/
> 
> 
> Testing
> -------
> 
> No.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141206/0b482167/attachment.html>