Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

Nicolás Alvarez nicolas.alvarez at gmail.com
Sat Dec 6 00:15:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121075/#review71451
-----------------------------------------------------------

Ship it!


Ship It!

- Nicolás Alvarez


On Nov. 8, 2014, 7:13 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121075/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 7:13 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> -------
> 
> Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail.
> 
> 
> Diffs
> -----
> 
>   src/kbookmarkowner.h 4d6fe0b 
> 
> Diff: https://git.reviewboard.kde.org/r/121075/diff/
> 
> 
> Testing
> -------
> 
> It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141206/7161de0a/attachment.html>


More information about the Kde-frameworks-devel mailing list