Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

[Christoph Feck]

> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote:
> > After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory.
> 
> Laurent Navet wrote:
>     do you want me to move this from kdeexamples to kwidgetsaddons ?
> 
> Christoph Feck wrote:
>     While it indeed makes sense to showcase the features of a framework inside that framework, here I see the problem that the code currently depends on other frameworks.
>     
>     So either we showcase multiple frameworks, and have a separate examples repository, or we showcase a single framework, and make sure the examples do not drag in other frameworks.
> 
> Christoph Feck wrote:
>     Has a decision been made to strip it down to Qt-only dependencies (and KWidgetAddons of course :) for adding it to KWidgetAddons, or ship it in a separate repository, where we can showcase it together with the other useful KF5 features, such as translations, kconfig etc.?
> 
> Dominik Haumann wrote:
>     As someone who worked on KMessageWidget quite a lot, I'd be in favour of having this demo app in an examples directory, as I think it makes sense to keep the code close together.
> 
> Laurent Navet wrote:
>     up !

Laurent, the example still uses unrelated frameworks, see my comments above.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review64357
-----------------------------------------------------------


On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 9:33 a.m.)
> 
> 
> Review request for KDE Examples, KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: kdeexamples
> 
> 
> Description
> -------
> 
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
> 
> Comments appreciated,
> 
> 
> Diffs
> -----
> 
>   kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac 
>   kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 
>   kdeui/kmessagewidgetdemo/window.h d3a67c8 
>   kdeui/kmessagewidgetdemo/window.cpp 9786da6 
> 
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
> 
> 
> Testing
> -------
> 
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141205/01f39053/attachment.html>