Review Request 121356: Do not change the volume when playing a notification

David Edmundson david at davidedmundson.co.uk
Thu Dec 4 21:50:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121356/#review71379
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 4, 2014, 9:12 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121356/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 9:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Playing a notification should be that, playing a notification.
> 
> Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/
> 
> 
> Diffs
> -----
> 
>   src/notifybysound.cpp 09a80dd 
> 
> Diff: https://git.reviewboard.kde.org/r/121356/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141204/68f5c020/attachment.html>


More information about the Kde-frameworks-devel mailing list