Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121233/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 1:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
-------

KDesktopFileActions::run did not accept the optional argument
QByteArray asn which meant that any application startup id passed
to KRun got dropped at this point when launching a desktop file.

This change ensures that an ASN is passed along. This way we can
properly pass around the application which launched the process
and the timestamp which triggered the launch (otherwise klauncher
needs a roundtrip to the X-Server to fetch the latest timestamp).


Diffs
-----

  src/widgets/kdesktopfileactions.h 7b96ff079c752436aebd0b134b930171ea088f48 
  src/widgets/kdesktopfileactions.cpp 0cbeb00f0c0344b5b204f0d18b7c269da6c99e7f 
  src/widgets/krun.cpp c623b583716e492622e0d1d1c9cec485c6bcf163 

Diff: https://git.reviewboard.kde.org/r/121233/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141202/f10f18b1/attachment.html>