libnm-qt - a new KF5 framework for Tier 1?

[Jan Grulich]

On Thursday 20 of November 2014 17:08 David Edmundson wrote:
> > > > > I'm not a fan of the propertiesChanged() method making it into the
> > > > > public
> > > > > API which we see in most classes, it's very much an implementation
> > > > > detail
> > > > > for QDBusAbstractInterface being rubbish.
> > 
> > Should we move it to private classes?
> > 
> > I would.
> 
> Or make each subclass connect to the interface propertyChanged signal
> itself and not have the propagation.

Done, I moved all propertiesChanged() slots to private classes.
See https://git.reviewboard.kde.org/r/121304/

Anything else?

Jan
-- 
Jan Grulich 
Red Hat Czech, s.r.o
jgrulich at redhat.com