Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2

Martin Gräßlin mgraesslin at kde.org
Mon Dec 1 15:01:34 UTC 2014



> On June 26, 2014, 9:29 a.m., Thomas Lübking wrote:
> > this is however not ABI relevant, so depending on schedules one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-)
> 
> Martin Gräßlin wrote:
>     yeah I'm fine with delaying to post 5.0 in frameworks. Means KWin 5.0 will not have full support for it. But if it gets into KWindowSystem 5.1 we can still add it in a minor KWin relase (and get killed by distros for increasing requirement in a minor release :-P ).
> 
> Thomas Lübking wrote:
>     if this is causing downstream dep issues, maybe a generic NETRootInfo::setSupported(const QString property) might be a good idea?
> 
> Martin Gräßlin wrote:
>     could be something to look into for 5.1, good idea.
> 
> David Edmundson wrote:
>     5.1 has been and gone. What's the status of this?
> 
> Thomas Lübking wrote:
>     There hasn't even been a request from gtk+ devs to get this into NETWM.
>     I was about to rant that the GTK ("gnome first") devs give a damn about interoperability and expect to "run after us!", but google (wanted to be sure ;-) pushed up
>     http://people.freedesktop.org/~cbrill/dri-log//dri-devel-2014-05-08.log
>     
>     "07:45 #wayland: < Jasper> mgraesslin, whenever I send mails to wm-spec-list I don't get any replies, so I stopped bothering"
>     
>     "Jasper" is apparently the one who added support to mutter.
>     
>     ---
>     
>     @Martin
>     I would suggest to either declare NETWM dead XOR formalize the board.
>     
>     Eg. one would define a "high council" consisting of the maintainers of the relevant™ WMs (KWin, Mutter, Openbox and Enlightenment for sure. Compiz IFFFFFF Canonical promises to behave. Eventually awesome? I probably forgot an obvious one) an setup some rules.
>     
>     a) A proposal of a high council member w/o veto of any other HC member within 21 days is in.
>     b) A proposal of a non member that has seen no reaction from high council or delegates within 21 days causes reposts with increasing frequence.
>     c) New features MUST be announced as supported by the WM, ignoring that hint and just expecting it is a client bug by definition.
>     d) A proposal containing the term "should" or any equivalent is auto-invalid ;-)
>     
>     
>     I'd also suggest to move from wm-spec-list at gnome.org to sth. like netwm at lists.freedesktop.org and/or have a fdo bugzilla bugtracker for handling concerns/proposals.

> 5.1 has been and gone. What's the status of this?

it's an insufficient solution. There are a bazillion of issues which need to be addressed like
* button position order
* geometries of each button (we need to know the position of the close button to recognize a failed attempt to close the window)
* ...

This is just a part of the overall puzzle and I had tried to take it to the NETWM spec list, but hadn't had the momentum to complete the process (after all I have zero interest in fixing behind GTK). It's a lot of work and honestly I think it's a wasted effort as GTK should do the sane thing and disable their decorations on other desktops.

Nevertheless we should make sure that these things will be done properly in the XdgShell for Wayland. Jasper is the main developer of the protocol and I consider him cooperative. I plan to look on the protocol sometime soon and prepare a "KDE view" on it. In my opinion most things missing are related to decorations (e.g. button ordering, etc.). I'll also try to get once again an agreement on that we need to be able to disable decorations completely for convergence. On second thought: it might be better some other KDE dev proposes this not to run into it being ignored because I'm a known opponent of CSD.

For this particular item: if we want to add support we should do it in KWin, but again: I don't care.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118946/#review60994
-----------------------------------------------------------


On June 26, 2014, 9:22 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118946/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 9:22 a.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2
> 
> Although non-standard it needs to be added to the NET::PRoperties2
> in order to have KWin announce it in the supported section.
> 
> As soon as this gets standardized WM2ShowWindowMenu can be changed
> to point to both the proprietary GTK hint and the standardized hint.
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e 
>   src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf 
>   src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 
> 
> Diff: https://git.reviewboard.kde.org/r/118946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/91270460/attachment.html>


More information about the Kde-frameworks-devel mailing list