Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121175/#review71185
-----------------------------------------------------------

Ship it!



autotests/kemailaddresstest.cpp
<https://git.reviewboard.kde.org/r/121175/#comment49735>

    that's me alright :)



src/kemailaddress.cpp
<https://git.reviewboard.kde.org/r/121175/#comment49736>

    scheme() is lowercase nowadays, so toLower() is unnecessary.


- David Faure


On Nov. 19, 2014, 1:23 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121175/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 1:23 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> This class can be very useful to many applications that need to deal with email
> address validation, and so it should not be hidden somewhere in PIM, but
> should be available in some more visibile framework. Also I need to kill the
> KPimUtils framework, and we don't really have any better-fitting framework
> available at this moment :)
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 825e9e8 
>   autotests/kemailaddresstest.h PRE-CREATION 
>   autotests/kemailaddresstest.cpp PRE-CREATION 
>   src/CMakeLists.txt 8b5c4a0 
>   src/kemailaddress.h PRE-CREATION 
>   src/kemailaddress.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121175/diff/
> 
> 
> Testing
> -------
> 
> Test passes.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/893bd62d/attachment.html>