Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121233/#review71168
-----------------------------------------------------------


This isn't a Qt5/KF5 porting issue, right? IIUC the same issue happens in kdelibs4? This isn't an argument against fixing it, of course, I'm just curious.


src/widgets/kdesktopfileactions.h
<https://git.reviewboard.kde.org/r/121233/#comment49726>

    The other way around. This is SC (existing code will still compile fine), but not BC (the signature changed, so upgrading kio will break existing apps until they get recompiled).
    
    You can't rely on the assumption that no app is calling this. LXR agrees, but there are more apps using KIO than those in LXR.
    
    On the other hand, we could decide to deprecate it, if we don't see the usefulness of it. And then we can put the new func (with 3 args) in a kdesktopfileactions_p.h, which only kio will be able to call. I would be OK with that.


- David Faure


On Nov. 24, 2014, 6:53 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121233/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 6:53 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KDesktopFileActions::run did not accept the optional argument
> QByteArray asn which meant that any application startup id passed
> to KRun got dropped at this point when launching a desktop file.
> 
> This change ensures that an ASN is passed along. This way we can
> properly pass around the application which launched the process
> and the timestamp which triggered the launch (otherwise klauncher
> needs a roundtrip to the X-Server to fetch the latest timestamp).
> 
> 
> Diffs
> -----
> 
>   src/widgets/kdesktopfileactions.cpp 0cbeb00f0c0344b5b204f0d18b7c269da6c99e7f 
>   src/widgets/kdesktopfileactions.h 7b96ff079c752436aebd0b134b930171ea088f48 
>   src/widgets/krun.cpp c623b583716e492622e0d1d1c9cec485c6bcf163 
> 
> Diff: https://git.reviewboard.kde.org/r/121233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/f2711bdc/attachment.html>