Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute
Alexander Richardson
arichardson.kde at gmail.com
Mon Dec 1 12:37:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121308/
-----------------------------------------------------------
Review request for KDE Frameworks, David Faure and Sebastian Kügler.
Repository: kcoreaddons
Description
-------
This breaks things such as passing a path relative to QT_PLUGIN_PATH
Diffs
-----
src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2
src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd
Diff: https://git.reviewboard.kde.org/r/121308/diff/
Testing
-------
unit tests still pass. I doubt anybody is relying on this path being absolute since the class is still very new (and mostly used with K/QPluginLoader which resolves those paths anyway)
I will adapt kplugininfotest in KService to this change.
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/a881e359/attachment.html>
More information about the Kde-frameworks-devel
mailing list