Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

[Milian Wolff]

> On Nov. 30, 2014, 2:29 p.m., Milian Wolff wrote:
> > src/kstandardaction.cpp, line 153
> > <https://git.reviewboard.kde.org/r/121218/diff/3/?file=330993#file330993line153>
> >
> >     is the call to `setCheckable` not required anymore? b/c that is otherwise missing on the new patch now, no?
> 
> Alexander Richardson wrote:
>     Now that create() uses a KToggleAction instead of a QAction it should not be necessary, right?

Ah ok, that can be. I don't know the internals good enough, just wanted to make sure :)


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/#review71120
-----------------------------------------------------------


On Nov. 30, 2014, 2:29 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121218/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 2:29 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Not sure if MSVC has the necessary type_traits working, but can't test that now since it don't have a Windows machine available.
> 
> 
> Diffs
> -----
> 
>   autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
>   src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
>   autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
>   src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
> 
> Diff: https://git.reviewboard.kde.org/r/121218/diff/
> 
> 
> Testing
> -------
> 
> The newly added unit test passes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141201/4edf7210/attachment.html>