Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120016/#review65610
-----------------------------------------------------------


Good point, we don't implement that spec yet.  ($desktop-mimeapps.list is missing too).

I'm not sure the syntax QStringList = list1 << list2 is portable to all compilers. It reads to me like it would modify list1.... Isn't it enough to use "+" here?

- David Faure


On Aug. 31, 2014, 11 a.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120016/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2014, 11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Read the mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS too, according to mime-apps-spec 1.0 .
> http://standards.freedesktop.org/mime-apps-spec/mime-apps-spec-1.0.html#file
> 
> This improves interoperability with applications using current glib/gio which now saves user mimeapps.list in XDG_CONFIG_HOME.
> 
> regards,
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change if the patch looks fine. Thanks.
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kmimeassociations.cpp efc16f4 
> 
> Diff: https://git.reviewboard.kde.org/r/120016/diff/
> 
> 
> Testing
> -------
> 
> tested with kservice 5.1.0 (Mageia Cauldron)
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140831/45533de3/attachment.html>