Review Request 120023: Fix crash in unit test when run with ASAN

[Albert Astals Cid]

> On ago. 31, 2014, 4:48 p.m., Milian Wolff wrote:
> > src/k7zip.cpp, line 562
> > <https://git.reviewboard.kde.org/r/120023/diff/1/?file=308904#file308904line562>
> >
> >     personally, I'd prefer the C++ way of casting over unsafe C-style casts every time.
> >     
> >     Also, what is the magic number 8? That should probably be sizeof(quint64), no?

personally i'm just copying from the rest of the file.

8 is not a magic number, is the number in the for loop


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120023/#review65603
-----------------------------------------------------------


On ago. 31, 2014, 2:46 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120023/
> -----------------------------------------------------------
> 
> (Updated ago. 31, 2014, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks, Mario Bensi and Mathieu Tarral.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Without this patch when running karchivetest with asan I get http://paste.kde.org/p3unh9jzk
> 
> Discovered in conjunction with Mathieu Tarral
> 
> 
> Diffs
> -----
> 
>   src/k7zip.cpp 4a88453 
> 
> Diff: https://git.reviewboard.kde.org/r/120023/diff/
> 
> 
> Testing
> -------
> 
> Test now passes
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140831/336c3f15/attachment-0001.html>