Review Request 120024: Prevent some false positive critical warnings for KStandardActions

Friedrich W. H. Kossebau kossebau at
Sun Aug 31 16:36:07 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks.

Repository: kxmlgui


In combination with, please read that one first.

This part of the patch does:
* make KActionCollection::setDefaultShortcuts() invokable per QMetaObject::invokeMethod, so KStandardAction::create(...) can access it
* make sure that setDefaultShortcuts is also called for KStandardActions created in the non-default-name addAction variant
* add a new constructor to KHelpMenu to allow passing an KActionCollection in, so all standardactions can be created from the beginning as items in the actioncollection, including setup with setDefaultShortcuts

Follow-up for KHelpMenu in KParts is


  src/kactioncollection.h 5dbc3c2 
  src/kactioncollection.cpp 6c7af0f 
  src/khelpmenu.h df820f2 
  src/khelpmenu.cpp 53397cc 
  src/kxmlguifactory.cpp c4ad97b 
  src/kxmlguiwindow.cpp bd89279 



With this and the other patches, I can see no more of those warnings for standard actions, both KWrite and Okteta.
Also all unit tests still work.


Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list