Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Alex Merry]

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote:
> > modules/ECMQueryQmake.cmake, line 1
> > <https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line1>
> >
> >     I think we need to be a bit more clever here. I'd go for a cache variable, and if (TARGET Qt5::qmake), set the default to that, otherwise set the default to just "qmake".

You might also consider doing
find_package(Qt5Core QUIET)
if this is only going to be included when KDE_ECM_INSTALL_TO_QT_SYS_DIR is set.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65382
-----------------------------------------------------------


On Aug. 27, 2014, 1:11 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 1:11 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in ECM.
> 
> 
> Diffs
> -----
> 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> -------
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140829/f3bee6fd/attachment.html>