Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119977/#review65445
-----------------------------------------------------------


Errr, what do you mean it doesn't do anything?

It's used http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5
http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cpp?v=kf5-qt5
http://lxr.kde.org/source/frameworks/kconfigwidgets/src/kstandardaction.cpp?v=kf5-qt5

- Albert Astals Cid


On ago. 28, 2014, 4:39 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119977/
> -----------------------------------------------------------
> 
> (Updated ago. 28, 2014, 4:39 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Mark setProgramIconName() as deprecated, it did not do anything since
> kcoreaddons no longer uses QtGui so it can not set the icon.
> 
> BUG: 337938
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.h 2d8bd5645150a57739e94f9f71b112b20ec0e01f 
>   src/lib/kaboutdata.cpp 5ad81de814c123f50b17bb542331459e15649f4b 
> 
> Diff: https://git.reviewboard.kde.org/r/119977/diff/
> 
> 
> Testing
> -------
> 
> compiled a program made with kapptemplate 4.14.1 which uses this function, successfully gives a warning during compile
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140828/de3d16af/attachment.html>