Review Request 119975: KDBusService shouldn't crash upon bad application name

Aleix Pol Gonzalez aleixpol at kde.org
Thu Aug 28 15:18:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119975/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdbusaddons


Description
-------

If the application name has a '-', Qt asserts. Instead of going there, remove the '-' and output a warning so the replacement is noticed and fixable.


Diffs
-----

  src/kdbusservice.cpp a9b7cc8 

Diff: https://git.reviewboard.kde.org/r/119975/diff/


Testing
-------

Ran tests, reproduced with an application.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140828/92491f84/attachment.html>


More information about the Kde-frameworks-devel mailing list