Review Request 119936: Add a basic unit test for KPluginInfo

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119936/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 2:56 nachm.)


Review request for KDE Frameworks.


Repository: kservice


Description
-------

Add a basic unit test for KPluginInfo


Diffs (updated)
-----

  autotests/CMakeLists.txt da83f46a9dcd1fa7801bead5715abf51cd12d668 
  autotests/kplugininfotest.cpp PRE-CREATION 
  src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 
  src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 

Diff: https://git.reviewboard.kde.org/r/119936/diff/


Testing
-------

Unit test passes, however I would like some feedback on the three TODO: comments. Is this intended behaviour or should it be fixed?


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140828/e64abe4a/attachment.html>