Review Request 119958: Fix thumbnails for mimetype groups.

Maarten De Meyer de.meyer.maarten at
Wed Aug 27 18:40:24 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks.

Repository: kio


Fix a regression in PreviewJob. This one was hard to find :)

KService::mimeTypes cannot handle mimetype groups. ex: text/*
Use KService::serviceTypes instead and ignore the first item which is
always type 'ThumbCreator'

This is the quick and easy solution. I could also add support for mimetype groups to KService::mimeTypes. (so that it return all mimetypes in a group) Not sure what the best solution is. Are groups only used in thumbnailer files?


  src/widgets/previewjob.cpp 55a3fb7 



I'm porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails.


Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list