Review Request 119940: Use style primitive to render custom tooltip rather than custom code

Hugo Pereira Da Costa hugo.pereira at free.fr
Tue Aug 26 14:38:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119940/
-----------------------------------------------------------

(Updated Aug. 26, 2014, 2:38 p.m.)


Review request for KDE Frameworks.


Changes
-------

added screenshots


Repository: kinfocenter


Description
-------

as title says
the current custom code was made to match oxygen, and does not fit breeze any more.
You end up with artifacts, incorrect rounding, wrong shadow etc.
also the current code is much simpler and works with all other themes too


Diffs
-----

  ToolTips/ktooltipwindow.cpp 0ef540c 
  ToolTips/ktooltipwindow_p.h a9ac30f 

Diff: https://git.reviewboard.kde.org/r/119940/diff/


Testing
-------

with oxygen, fusion, breeze


File Attachments (updated)
----------------

kinfocenter-before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/344a7dab-0dce-4a80-915b-8fccbd1b9f16__kinfocenter-before.png
kinfocenter-after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/dc2d618e-077f-4f49-ba02-11420927a068__kinfocenter-after.png


Thanks,

Hugo Pereira Da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140826/492af950/attachment.html>


More information about the Kde-frameworks-devel mailing list