Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

> On Aug. 25, 2014, 10:32 p.m., David Faure wrote:
> > kde-modules/KDEInstallDirs.cmake, line 340
> > <https://git.reviewboard.kde.org/r/119901/diff/2/?file=307587#file307587line340>
> >
> >     I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what it's about.
> >     
> >     Is this line enough? I thought you had to use option() to make the option available on the cmake command-line, but maybe I'm missing something.
> 
> Rohan Garg wrote:
>     I think ECM_INSTALL_PLUGINS_IN_QT_DIR would be wrong since it's used for both plugins and QtQuick imports.
> 
> David Faure wrote:
>     Yeah but as it is now, it sounds like EVERYTHING is going to be installed into the Qt dir :-)
>     
>     Calling it ECM_INSTALL_PLUGINS_AND_IMPORTS_IN_QT_DIR would be quite a mouthful.
>     
>     In fact, IMHO imports are kind of plugins too. That dir is indeed full of .so plugins... so yeah, I still prefer ECM_INSTALL_PLUGINS_IN_QT_DIR :)

Alright :).


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
-----------------------------------------------------------


On Aug. 25, 2014, 11:23 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 11:23 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in ECM.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> -------
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140825/9dbe79f6/attachment-0001.html>