Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice
Alexander Richardson
arichardson.kde at gmail.com
Sun Aug 24 12:14:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119356/
-----------------------------------------------------------
(Updated Aug. 24, 2014, 2:14 nachm.)
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
Unlike the original KConfig based tool it now includes all translations
for keys and not just the one for the current locale. Also added a unit
test for it.
Add a verbose option to desktoptojson
Also check for missing entries in the desktoptojson unit test
make the desktoptojson unit test less verbose
install a KF5CoreAddonsMacros.cmake with kcoreaddons_desktop_to_json()
Convert the .desktop files to a new .json format and adapt tests
This format is used by KPluginMetaData and allows removing all the
useless X-KDE-PluginInfo prefixes
Diffs (updated)
-----
CMakeLists.txt f45f573e18642c6cf246b90891cce24180a6898a
KF5CoreAddonsConfig.cmake.in c471006ee2c8f52b5c22c5edc617554f671237d1
KF5CoreAddonsMacros.cmake PRE-CREATION
autotests/CMakeLists.txt 96dd263b994ffdc59cec4add161394f7747dce9b
autotests/desktoptojsontest.cpp PRE-CREATION
src/CMakeLists.txt ef1eea63c92532eea7003c67b59bb3649bc02484
src/desktoptojson/CMakeLists.txt PRE-CREATION
src/desktoptojson/desktoptojson.h PRE-CREATION
src/desktoptojson/desktoptojson.cpp PRE-CREATION
src/desktoptojson/main.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119356/diff/
Testing
-------
Unit test works and passes.
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140824/e42b1d63/attachment.html>
More information about the Kde-frameworks-devel
mailing list