Review Request 119907: KIO: Correctly generate previews.
Eike Hein
hein at kde.org
Fri Aug 22 19:10:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119907/#review65072
-----------------------------------------------------------
Just as a little sanity check: Did you try with the Folder containment in Plasma or KFileDialog? (They use KFilePreviewGenerator while Dolphin doesn't, so useful to test as a major consumer of PreviewJobs.)
- Eike Hein
On Aug. 22, 2014, 6:57 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119907/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 6:57 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> During the porting of PreviewJob some mistakes were made.
> Currently thumbnails are created as .cache/$appName/thumbnails/normal/kde-tmp-XXXXXX.png
> Now they are saved as they should be .cache/thumbnails/normal/$md5.png
>
>
> Diffs
> -----
>
> src/widgets/previewjob.cpp c65d683
>
> Diff: https://git.reviewboard.kde.org/r/119907/diff/
>
>
> Testing
> -------
>
> Open a folder with images in dolphin, check the location and name.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140822/1a2e0a56/attachment.html>
More information about the Kde-frameworks-devel
mailing list