Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

[Martin Klapetek]

> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote:
> > Well, you only get the frameworks integration when you're running Plasma 5...
> > 
> > Actually, frameworksintegration should move to kde/workspace at least. It's not a framework.
> 
> Martin Klapetek wrote:
>     Well the message boxes won't do any sounds without "KMessageBoxNotify" which is part of the frameworksintegration, so it makes sense to ship the notifyrc file (used mainly for KMessageBox) together with it.
> 
> Aleix Pol Gonzalez wrote:
>     So what happens if you open a KMessageBox on Gnome or Windows? We require frameworksintegration?
> 
> Martin Klapetek wrote:
>     I would have thought so. KMessageBox is part of KWidgetsAddons, tier1. The sound in our workspace is handled by KNotification, tier3. So KMessageBox cannot depend directly on KNotification, so I guess it was decided to provide this functionality as a plugin, which happens to be part of frameworkintegration.
> 
> Harald Sitter wrote:
>     FWIW this runtime dependency ultimately should/could go away if/when phonon grows a class to do minimal-overhead notification playback with fallback logic and platform integration and whatnot. Until then the only way to work around the runtime dep is to do a fallback inside kmessagebox to use phonon directly and try to play a sound file (of which one somehow would have to get the path), which actually might be suitable solution until something better comes along.
> 
> Martin Klapetek wrote:
>     In the meantime and with Plasma 5 as a main user in mind, I'd like to get this in before the next frameworks release ;)

I'll just push it later today if there will be no objections.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119563/#review63634
-----------------------------------------------------------


On Aug. 1, 2014, 4:29 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119563/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 4:29 p.m.)
> 
> 
> Review request for KDE Frameworks and Harald Sitter.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Add plasma_workspace.notifyrc to be installed with frameworkintegration. This file contains basic notification events and has preconfigured sounds for those, with this for example KMessageBox plays a sound etc. It's what used to be kde.notifyrc in KDE4 world.
> 
> I put it in frameworkintegration as it seems to be the best place for it, the default sounds etc. are a workspace integration after all, but plasma-workspace is too high in the stack.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt af3cce8 
>   plasma_workspace.notifyrc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140822/cb59ed2d/attachment.html>