Review Request 119884: Add cursor shape property to MouseEventListener

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119884/#review65027
-----------------------------------------------------------

Ship it!



src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h
<https://git.reviewboard.kde.org/r/119884/#comment45448>

    ws



src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp
<https://git.reviewboard.kde.org/r/119884/#comment45449>

    accolades, please


- Sebastian Kügler


On Aug. 21, 2014, 3:17 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119884/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 3:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 337062
>     https://bugs.kde.org/show_bug.cgi?id=337062
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Given MouseEventListener is sometimes used as a drop in replacement for
> MouseArea with added functionality it's useful to have some more of the
> same functions as MouseArea.
> 
> This simply exposes an existing methods on QQuickItem as a property.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h 329de62 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp 7948c09 
> 
> Diff: https://git.reviewboard.kde.org/r/119884/diff/
> 
> 
> Testing
> -------
> 
> Adjusted panel config as described in https://bugs.kde.org/show_bug.cgi?id=337062 -  panel toolbox has handles in disguise 
> 
> 
> I could do it with a mousearea on top instead of changing MouseEventListener, but then we'd have:
> MouseArea on top of MouseEventListener on top of a button which is a MouseArea....
> 
> and I figured there'd be potential other users of this property long term.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140822/882f5bea/attachment.html>