Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

Jonathan Riddell jr at jriddell.org
Thu Aug 21 12:56:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119881/#review64976
-----------------------------------------------------------


KConfig has multiple libraries but only 1 KF5ConfigConfig.cmake and 1 KF5ConfigConfigVersion.cmake so maybe this shouldn't be added but rather the check for it removed from plasma-desktop

- Jonathan Riddell


On Aug. 21, 2014, 10:30 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119881/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 10:30 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/CMakeLists.txt cc5554afb2d931611d6949409a5569b409e70b0a 
> 
> Diff: https://git.reviewboard.kde.org/r/119881/diff/
> 
> 
> Testing
> -------
> 
> compiles and installs, plasma desktop now compiles when I add a required KF5 version
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140821/9c62cad7/attachment.html>


More information about the Kde-frameworks-devel mailing list